Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DiagnosticSource 7.0 and drop netcoreapp3.1 target #3351

Merged
merged 6 commits into from
Jun 8, 2022

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Jun 8, 2022

Merging this to a new net7.0 branch for so we have a place to start work that is dependent on DiagnosticSource 7.0.

@alanwest alanwest requested a review from a team June 8, 2022 00:06
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets re-enable CI for this branch as well.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3351 (ef1d7ed) into net7.0 (efc55d5) will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           net7.0    #3351      +/-   ##
==========================================
- Coverage   85.90%   85.70%   -0.20%     
==========================================
  Files         267      267              
  Lines        9383     9368      -15     
==========================================
- Hits         8060     8029      -31     
- Misses       1323     1339      +16     
Impacted Files Coverage Δ
...mentation/ExportClient/ExporterClientValidation.cs 30.00% <0.00%> (-70.00%) ⬇️
src/OpenTelemetry.Api/BaseProvider.cs 66.66% <0.00%> (-33.34%) ⬇️
...c/OpenTelemetry/Internal/TagAndValueTransformer.cs 80.00% <0.00%> (-20.00%) ⬇️
...Propagators/OpenTelemetryPropagatorsEventSource.cs 87.50% <0.00%> (-12.50%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 86.17% <0.00%> (-2.26%) ⬇️
...Exporter.Jaeger/ApacheThrift/Protocol/TProtocol.cs 91.30% <0.00%> (-0.86%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
...er.Jaeger/ApacheThrift/Protocol/TBinaryProtocol.cs 78.88% <0.00%> (-0.69%) ⬇️
... and 3 more

@alanwest
Copy link
Member Author

alanwest commented Jun 8, 2022

lets re-enable CI for this branch as well.

Enabled and passing. Going to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants