Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http.scheme tag to HttpClient instrumentation #3464

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Jul 20, 2022

Fixes #.
part of #3373

Changes

Adding http.scheme for HttpClient tracing instrumentation. The tag already exists for metrics part and is recommended according to spec.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar changed the title Add http.scheme tag to HttpClient intrumentation Add http.scheme tag to HttpClient instrumentation Jul 20, 2022
@vishweshbankwar vishweshbankwar marked this pull request as ready for review July 20, 2022 18:18
@vishweshbankwar vishweshbankwar requested a review from a team July 20, 2022 18:18
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #3464 (62b1c26) into main (95419ed) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
- Coverage   86.35%   86.34%   -0.02%     
==========================================
  Files         267      267              
  Lines        9633     9634       +1     
==========================================
- Hits         8319     8318       -1     
- Misses       1314     1316       +2     
Impacted Files Coverage Δ
...tp/Implementation/HttpHandlerDiagnosticListener.cs 73.49% <100.00%> (+0.32%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 82.24% <0.00%> (-1.87%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 97.65% <0.00%> (+0.78%) ⬆️

@utpilla utpilla merged commit 54e83a9 into open-telemetry:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants