Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hosting] Remove obsolete methods ahead of 1.4.0 release #4071

Merged
merged 16 commits into from
Feb 23, 2023

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Jan 10, 2023

If you are reading this because you upgraded to 1.4.0 and your code no longer compiles, sorry! Much discussion went into this and we decided as a group it was the best path forward to not have obsolete code in our first shipped stable version. If you want to get up and running using the old API, you may use the RC version: 1.4.0-rc.4. That version contains everything in 1.4.0 minus this PR removing the old API.

Migration steps

Old style:

services.AddOpenTelemetryTracing(builder => /* configuration */);
services.AddOpenTelemetryMetrics(builder => /* configuration */);

New style:

services.AddOpenTelemetry()
  .WithTracing(builder => /* configuration */)
  .WithMetrics(builder => /* configuration */);

Other APIs...

  • Configure is available by casting the provider builder as either IDeferredTracerProviderBuilder or IDeferredMeterProviderBuilder.
  • GetServices is now available as ConfigureServices.

Changes

  • Removes all the hosting APIs obsoleted in v1.4.0 development.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #4071 (5aad68f) into main (bdf1e08) will increase coverage by 0.15%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4071      +/-   ##
==========================================
+ Coverage   85.55%   85.71%   +0.15%     
==========================================
  Files         291      289       -2     
  Lines       11398    11374      -24     
==========================================
- Hits         9752     9749       -3     
+ Misses       1646     1625      -21     
Impacted Files Coverage Δ
...ensions.Hosting/OpenTelemetryServicesExtensions.cs 100.00% <ø> (+60.00%) ⬆️
...lementation/SqlClientInstrumentationEventSource.cs 70.83% <0.00%> (-4.17%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 82.24% <0.00%> (-1.87%) ⬇️

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jan 18, 2023
@TimothyMothra
Copy link
Contributor

bump to remove stale

@github-actions github-actions bot removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jan 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Feb 8, 2023
@github-actions github-actions bot removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Feb 11, 2023
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Feb 22, 2023
@CodeBlanch CodeBlanch marked this pull request as ready for review February 23, 2023 17:58
@CodeBlanch CodeBlanch requested a review from a team February 23, 2023 17:58
Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM.

@CodeBlanch CodeBlanch merged commit 5b1889d into open-telemetry:main Feb 23, 2023
@CodeBlanch CodeBlanch deleted the hosting-stable branch February 23, 2023 20:44
tomkerkhove added a commit to tomkerkhove/promitor that referenced this pull request Feb 26, 2023
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
tomkerkhove added a commit to tomkerkhove/promitor that referenced this pull request Feb 27, 2023
* Bump OTEL & xUnit

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Fix breaking change open-telemetry/opentelemetry-dotnet#4071

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Bump Arcus deps

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Fix code quality

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Fix failing test

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Bump System.Drawing.Common to fix vulnerability

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

---------

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants