[HttpClient] Fix missing metric during network failures #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4098 +/- ##
==========================================
+ Coverage 84.73% 85.70% +0.97%
==========================================
Files 295 289 -6
Lines 11513 11375 -138
==========================================
- Hits 9755 9749 -6
+ Misses 1758 1626 -132
|
3 tasks
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
github-actions
bot
removed
the
Stale
…s://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/fix-httpclient-metric-network-failure
Kielek
approved these changes
Feb 20, 2023
utpilla
approved these changes
Feb 28, 2023
cijothomas
reviewed
Mar 1, 2023
| @@ -90,35 +90,37 @@ | |||
| { | |||
| "name": "Call that cannot resolve DNS will be reported as error span", | |||
| "method": "GET", | |||
| "url": "https://sdlfaldfjalkdfjlkajdflkajlsdjf.sdlkjafsdjfalfadslkf.com/", | |||
| "url": "http://sdlfaldfjalkdfjlkajdflkajlsdjf:{port}/", | |||
There was a problem hiding this comment.
wanted to validate we capture port information as well.
cijothomas
reviewed
Mar 1, 2023
cijothomas
approved these changes
Mar 1, 2023
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
|
/easycla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4055
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes