-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example / proof of concept to achieve a combination of head-based sampling + a basic form of tail-based sampling at a span level. #4206
Example / proof of concept to achieve a combination of head-based sampling + a basic form of tail-based sampling at a span level. #4206
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
=======================================
Coverage 84.42% 84.43%
=======================================
Files 298 298
Lines 11851 11851
=======================================
+ Hits 10005 10006 +1
+ Misses 1846 1845 -1 |
docs/trace/advanced/tail-based-sampling-span-level/ParentBasedElseAlwaysRecordSampler.cs
Outdated
Show resolved
Hide resolved
docs/trace/advanced/tail-based-sampling-span-level/Examples.TailBasedSamplingAtSpanLevel.csproj
Outdated
Show resolved
Hide resolved
…ilBasedSamplingAtSpanLevel.csproj Co-authored-by: Timothy Mothra <tilee@microsoft.com>
docs/trace/advanced/tail-based-sampling-span-level/TailSamplingProcessor.cs
Outdated
Show resolved
Hide resolved
docs/trace/advanced/tail-based-sampling-span-level/TailSamplingProcessor.cs
Outdated
Show resolved
Hide resolved
docs/trace/tail-based-sampling-span-level/tail-based-sampling-example.csproj
Outdated
Show resolved
Hide resolved
docs/trace/tail-based-sampling-span-level/tail-based-sampling-example.csproj
Outdated
Show resolved
Hide resolved
docs/trace/tail-based-sampling-span-level/tail-based-sampling-example.csproj
Outdated
Show resolved
Hide resolved
…lyanaj/opentelemetry-dotnet into kalyanaj-tailsampling-example
docs/trace/tail-based-sampling-span-level/TailSamplingProcessor.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left few small comments. Please address them before merging. Thank you!
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
This is an example / proof of concept to achieve a combination of head-based sampling + a basic form of tail-based sampling at a span level.
Fixes #4205 .
Changes
This is an exploration/proof of concept of Tail-based sampling at a span level by using the extensibility mechanisms in the SDK. This is a way to achieve a combination of head-based sampling (based on probabilistic sampling) and a way to get all failure spans (non-probabilistic sampling: e.g., based on failure spans).
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes