Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example / proof of concept to achieve a combination of head-based sampling + a basic form of tail-based sampling at a span level. #4206

Merged
merged 16 commits into from
Mar 10, 2023

Conversation

kalyanaj
Copy link
Contributor

This is an example / proof of concept to achieve a combination of head-based sampling + a basic form of tail-based sampling at a span level.
Fixes #4205 .

Changes

This is an exploration/proof of concept of Tail-based sampling at a span level by using the extensibility mechanisms in the SDK. This is a way to achieve a combination of head-based sampling (based on probabilistic sampling) and a way to get all failure spans (non-probabilistic sampling: e.g., based on failure spans).

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@kalyanaj kalyanaj requested a review from a team February 18, 2023 21:14
@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #4206 (4ed2c69) into main (a1ea6d6) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 4ed2c69 differs from pull request most recent head 20bbdcf. Consider uploading reports for the commit 20bbdcf to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4206   +/-   ##
=======================================
  Coverage   84.42%   84.43%           
=======================================
  Files         298      298           
  Lines       11851    11851           
=======================================
+ Hits        10005    10006    +1     
+ Misses       1846     1845    -1     

see 3 files with indirect coverage changes

…ilBasedSamplingAtSpanLevel.csproj

Co-authored-by: Timothy Mothra <tilee@microsoft.com>
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left few small comments. Please address them before merging. Thank you!

Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants