Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Avoid boxing of status code tags #4361

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Apr 4, 2023

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team April 4, 2023 19:04
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #4361 (b4ba9dc) into main (b2fb873) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4361      +/-   ##
==========================================
+ Coverage   84.79%   84.82%   +0.02%     
==========================================
  Files         299      300       +1     
  Lines       12057    12065       +8     
==========================================
+ Hits        10224    10234      +10     
+ Misses       1833     1831       -2     
Impacted Files Coverage Δ
...tp/Implementation/HttpHandlerDiagnosticListener.cs 74.22% <100.00%> (ø)
...ementation/HttpHandlerMetricsDiagnosticListener.cs 95.23% <100.00%> (ø)
...plementation/HttpWebRequestActivitySource.netfx.cs 80.23% <100.00%> (ø)
...rumentation.Http/Implementation/TelemetryHelper.cs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

#pragma warning restore SA1509 // Opening braces should not be preceded by blank line
static TelemetryHelper()
{
BoxedStatusCodes = new object[500];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesNK FYI.

@CodeBlanch CodeBlanch merged commit 78abc68 into open-telemetry:main Apr 4, 2023
@CodeBlanch CodeBlanch deleted the http-statuscode-boxing branch April 4, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants