-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AOT] suppress IL2026 #4428
[AOT] suppress IL2026 #4428
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4428 +/- ##
==========================================
+ Coverage 83.35% 84.05% +0.69%
==========================================
Files 313 312 -1
Lines 12513 12339 -174
==========================================
- Hits 10430 10371 -59
+ Misses 2083 1968 -115
|
src/OpenTelemetry.Exporter.Console/OpenTelemetry.Exporter.Console.csproj
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Jaeger/OpenTelemetry.Exporter.Jaeger.csproj
Outdated
Show resolved
Hide resolved
...Telemetry.Exporter.OpenTelemetryProtocol/OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Zipkin/OpenTelemetry.Exporter.Zipkin.csproj
Outdated
Show resolved
Hide resolved
src/OpenTelemetry/Internal/UnconditionalSuppressMessageAttribute.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.Zipkin/OpenTelemetry.Exporter.Zipkin.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
src/OpenTelemetry/Internal/UnconditionalSuppressMessageAttribute.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for all the work here.
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Towards #3429
Related to: dotnet/runtime#85274
Changes
Suppress non-real issues (https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/trim-warnings/il2026) with the approach from this doc:
https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming#unconditionalsuppressmessage
list of warnings with this code change:
testlog_2.txt
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes