Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOT] suppress IL2026 #4428

Merged
merged 27 commits into from
May 3, 2023
Merged

Conversation

Yun-Ting
Copy link
Contributor

@Yun-Ting Yun-Ting commented Apr 24, 2023

Towards #3429
Related to: dotnet/runtime#85274

Changes

Suppress non-real issues (https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/trim-warnings/il2026) with the approach from this doc:
https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming#unconditionalsuppressmessage

list of warnings with this code change:
testlog_2.txt

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@Yun-Ting Yun-Ting marked this pull request as ready for review April 24, 2023 22:54
@Yun-Ting Yun-Ting requested a review from a team April 24, 2023 22:54
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #4428 (74e0063) into main (c73a70d) will increase coverage by 0.69%.
The diff coverage is 0.00%.

❗ Current head 74e0063 differs from pull request most recent head 3729720. Consider uploading reports for the commit 3729720 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4428      +/-   ##
==========================================
+ Coverage   83.35%   84.05%   +0.69%     
==========================================
  Files         313      312       -1     
  Lines       12513    12339     -174     
==========================================
- Hits        10430    10371      -59     
+ Misses       2083     1968     -115     
Impacted Files Coverage Δ
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 82.02% <ø> (+1.81%) ⬆️
...nal/Shims/UnconditionalSuppressMessageAttribute.cs 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

Yun-Ting and others added 2 commits April 26, 2023 17:21
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Yun-Ting and others added 4 commits April 27, 2023 14:19
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Copy link
Contributor

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for all the work here.

src/OpenTelemetry/OpenTelemetry.csproj Outdated Show resolved Hide resolved
Yun-Ting and others added 2 commits April 28, 2023 09:31
@utpilla utpilla merged commit 88e8439 into open-telemetry:main May 3, 2023
@Yun-Ting Yun-Ting deleted the yunl/suppress2026 branch May 3, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants