-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Exemplars internal #4533
Mark Exemplars internal #4533
Conversation
#pragma warning disable SA1623 // The property's documentation summary text should begin with: `Gets or sets` | ||
/// <summary> | ||
/// Represents an Exemplar data. | ||
/// </summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird.. the style cops didn't catch this before? 👮♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It complains about it only when I mark the struct internal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why disable the warning instead of just updating the text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you just have an annoying "unnecessary using" problem, but other than that LETM (looks exemplary to me)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4533 +/- ##
==========================================
+ Coverage 85.30% 85.60% +0.29%
==========================================
Files 320 320
Lines 12647 12611 -36
==========================================
+ Hits 10789 10796 +7
+ Misses 1858 1815 -43
|
@utpilla Please add entry in changelog, so users won't be surprised. You can hint that Exemplars will be added back for the 1.6* pre-releases immediately after 1.5 stable is out. |
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
Changes