Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Exemplars internal #4533

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jun 1, 2023

Changes

  • Mark Exemplars internal to exclude it from the stable release

@utpilla utpilla requested a review from a team June 1, 2023 00:21
Comment on lines +21 to 24
#pragma warning disable SA1623 // The property's documentation summary text should begin with: `Gets or sets`
/// <summary>
/// Represents an Exemplar data.
/// </summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird.. the style cops didn't catch this before? 👮‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It complains about it only when I mark the struct internal.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disable the warning instead of just updating the text?

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you just have an annoying "unnecessary using" problem, but other than that LETM (looks exemplary to me)

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #4533 (26e6f47) into main (0ddbdb4) will increase coverage by 0.29%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4533      +/-   ##
==========================================
+ Coverage   85.30%   85.60%   +0.29%     
==========================================
  Files         320      320              
  Lines       12647    12611      -36     
==========================================
+ Hits        10789    10796       +7     
+ Misses       1858     1815      -43     
Impacted Files Coverage Δ
...elemetry.Exporter.Console/ConsoleMetricExporter.cs 0.00% <ø> (ø)
...tryProtocol/Implementation/MetricItemExtensions.cs 94.85% <ø> (+8.25%) ⬆️
.../Metrics/Builder/MeterProviderBuilderExtensions.cs 83.76% <ø> (ø)
...emetry/Metrics/Exemplar/AlwaysOffExemplarFilter.cs 0.00% <ø> (ø)
...lemetry/Metrics/Exemplar/AlwaysOnExemplarFilter.cs 100.00% <ø> (ø)
src/OpenTelemetry/Metrics/Exemplar/Exemplar.cs 100.00% <ø> (ø)
...metry/Metrics/Exemplar/TraceBasedExemplarFilter.cs 0.00% <ø> (ø)
src/OpenTelemetry/Metrics/MetricPoint.cs 61.79% <ø> (ø)

... and 5 files with indirect coverage changes

@alanwest alanwest merged commit ccfbcc6 into open-telemetry:main Jun 1, 2023
@cijothomas
Copy link
Member

@utpilla Please add entry in changelog, so users won't be surprised. You can hint that Exemplars will be added back for the 1.6* pre-releases immediately after 1.5 stable is out.

mfogliatto pushed a commit to mfogliatto/opentelemetry-dotnet that referenced this pull request Jun 10, 2023
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
@utpilla utpilla deleted the utpilla/Mark-Exemplars-Internal branch November 3, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants