[sdk-logs] Expose logging SDK implementation as public #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4568 +/- ##
==========================================
- Coverage 85.19% 85.13% -0.07%
==========================================
Files 320 320
Lines 12678 12679 +1
==========================================
- Hits 10801 10794 -7
- Misses 1877 1885 +8
|
utpilla
reviewed
Jun 8, 2023
utpilla
approved these changes
Jun 8, 2023
utpilla
reviewed
Jun 8, 2023
cijothomas
reviewed
Jun 9, 2023
src/OpenTelemetry/Logs/LogRecord.cs
Outdated
| @@ -157,7 +160,7 @@ public ActivityTraceFlags TraceFlags | |||
| /// <summary> | |||
| /// Gets or sets the log <see cref="Microsoft.Extensions.Logging.LogLevel"/>. | |||
| /// </summary> | |||
| // todo: [Obsolete("Use Severity instead LogLevel will be removed in a future version.")] | |||
| [Obsolete("Use Severity instead LogLevel will be removed in a future version.")] | |||
There was a problem hiding this comment.
Suggested change
| [Obsolete("Use Severity instead LogLevel will be removed in a future version.")] | |
| [Obsolete("Use Severity instead LogLevel will be removed in a future release with a major version.")] |
There was a problem hiding this comment.
I think a bit more discussion is needed around our strategy on this and then we can land a policy doc + update all the warnings we have sprinkled around?
/cc @alanwest
vishweshbankwar
approved these changes
Jun 9, 2023
utpilla
approved these changes
Jun 9, 2023
mfogliatto
pushed a commit
to mfogliatto/opentelemetry-dotnet
that referenced
this pull request
Jun 10, 2023
utpilla
reviewed
Jul 12, 2023
| * Obsoleted `LogRecord.LogLevel` in favor of the `LogRecord.Severity` property | ||
| which matches the [OpenTelemetry Specification > Logs DataModel > Severity | ||
| definition](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#field-severitynumber). | ||
| ([#4433](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4433)) |
There was a problem hiding this comment.
The PR number needs to be corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4433
Changes
OpenTelemetryand removes the addedInternalsVisibleTosMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes