-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove zero bucket for the histogram buckets for ASP.NET Core and HttpClient metrics #5021
Remove zero bucket for the histogram buckets for ASP.NET Core and HttpClient metrics #5021
Conversation
src/OpenTelemetry/CHANGELOG.md
Outdated
([#5008](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5008)) | ||
|
||
* Remove the bucket with value `0` for histogram buckets for metrics from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need this entry as the above entry already shows the buckets without 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR associated with the above entry adds the zero bucket
This PR removes the zero bucket for the previously added metrics as well. I thought it's better to just list out the correct buckets even for the above entry.
Codecov Report
@@ Coverage Diff @@
## main #5021 +/- ##
==========================================
+ Coverage 83.38% 83.43% +0.05%
==========================================
Files 296 296
Lines 12385 12385
==========================================
+ Hits 10327 10334 +7
+ Misses 2058 2051 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #4908
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes