Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zero bucket for the histogram buckets for ASP.NET Core and HttpClient metrics #5021

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 3, 2023

Fixes #4908

Changes

  • Remove zero bucket for the histogram buckets for ASP.NET Core and HttpClient metrics

Please provide a brief description of the changes here.

Merge requirement checklist

  • Appropriate CHANGELOG.md files updated for non-trivial changes

@utpilla utpilla requested a review from a team November 3, 2023 01:27
([#5008](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5008))

* Remove the bucket with value `0` for histogram buckets for metrics from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need this entry as the above entry already shows the buckets without 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR associated with the above entry adds the zero bucket ☹️

This PR removes the zero bucket for the previously added metrics as well. I thought it's better to just list out the correct buckets even for the above entry.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #5021 (9b70052) into main (37481f1) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 9b70052 differs from pull request most recent head 31ee947. Consider uploading reports for the commit 31ee947 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5021      +/-   ##
==========================================
+ Coverage   83.38%   83.43%   +0.05%     
==========================================
  Files         296      296              
  Lines       12385    12385              
==========================================
+ Hits        10327    10334       +7     
+ Misses       2058     2051       -7     
Flag Coverage Δ
unittests 83.43% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/Metric.cs 96.46% <100.00%> (ø)

... and 7 files with indirect coverage changes

@utpilla utpilla merged commit 299a6c1 into open-telemetry:main Nov 3, 2023
70 checks passed
@utpilla utpilla deleted the utpilla/Update-Histogram-Buckets branch November 3, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default values for explicit histogram bucket boundaries for fixed set of metrics
3 participants