Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Misc changes #5053

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 15, 2023

Changes

  • Update non-prod packages
  • Other updates to use .NET 8 instead of .NET 7
  • Update unit tests:
    • Remove ConfigureAwait(false) to resolve the warning xUnit1030
    • Remove .Result and .Wait() and use async/await to resolve the warning xUnit1031

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #5053 (d1c968e) into main (b0f9607) will decrease coverage by 0.24%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5053      +/-   ##
==========================================
- Coverage   83.54%   83.30%   -0.24%     
==========================================
  Files         296      296              
  Lines       12473    12473              
==========================================
- Hits        10420    10391      -29     
- Misses       2053     2082      +29     
Flag Coverage Δ
unittests 83.30% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@utpilla utpilla changed the title Updates for .NET 8 [repo] Misc changes Nov 15, 2023
@utpilla utpilla marked this pull request as ready for review November 15, 2023 02:52
@utpilla utpilla requested a review from a team November 15, 2023 02:52
@utpilla utpilla merged commit c337d1e into open-telemetry:main Nov 15, 2023
70 checks passed
@utpilla utpilla deleted the utpilla/Updates-for-net8 branch November 23, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants