Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix histogram for dns.lookup.duration #5058

Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 16, 2023

Related to dotnet/runtime#92917.

I do not think that it is worth to keep support for .net8-rc/unstable. It should be fine to support only GA version.

Changes

Update metric name for DefaultHistogramBoundShortMappings. I do not think that it needs Changelog entry.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team November 16, 2023 09:29
@Kielek
Copy link
Contributor Author

Kielek commented Nov 16, 2023

Failing tests seems to be not related to changes.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #5058 (604832c) into main (e904994) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5058      +/-   ##
==========================================
- Coverage   83.54%   83.49%   -0.05%     
==========================================
  Files         296      296              
  Lines       12481    12481              
==========================================
- Hits        10427    10421       -6     
- Misses       2054     2060       +6     
Flag Coverage Δ
unittests 83.49% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/Metric.cs 96.46% <100.00%> (ø)

... and 7 files with indirect coverage changes

@utpilla utpilla merged commit bdd931e into open-telemetry:main Nov 16, 2023
36 checks passed
@Kielek Kielek deleted the dns.lookup.duration-histogram-fix branch November 16, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants