-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASP.NET Core] Remove OTEL_SEMCONV_STABILITY_OPT_IN #5066
[ASP.NET Core] Remove OTEL_SEMCONV_STABILITY_OPT_IN #5066
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5066 +/- ##
==========================================
- Coverage 83.44% 83.13% -0.32%
==========================================
Files 295 294 -1
Lines 12397 12321 -76
==========================================
- Hits 10345 10243 -102
- Misses 2052 2078 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -39,114 +39,106 @@ public IncomingRequestsCollectionsIsAccordingToTheSpecTests(WebApplicationFactor | |||
} | |||
|
|||
[Theory] | |||
[InlineData("/api/values", null, "user-agent", 503, "503")] | |||
[InlineData("/api/values", "?query=1", null, 503, null)] | |||
[InlineData("/api/values", null, "user-agent", 200, null)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why update the test cases? Do you simply want to add test cases for 200
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not update it in this PR. It was already there, it showing up due to file rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test/OpenTelemetry.Instrumentation.AspNetCore.Tests/MetricTests.cs
Outdated
Show resolved
Hide resolved
… of https://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/remove-semantic-conventions-opt-in-aspnetcore
nit: I found a comment that's still referencing the older spec. Can this be updated to reference the stable 1.23.0? Line 110 in eec09c9
|
Fixes #
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes