Only create a sibling activity when trace id, span id or trace state differ

[ngruson]

Fixes #4466

Only create a sibling activity when trace id, span id or trace state differ in the extracted activity context.
Traceflags are excluded from the comparison.

Changes

• Changed OnStartActivity in HttpInListener
• Added unit test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6250307) 83.38% compared to head (f842030) 83.10%.
Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5136      +/-   ##
==========================================
- Coverage   83.38%   83.10%   -0.28%     
==========================================
  Files         297      271      -26     
  Lines       12531    11958     -573     
==========================================
- Hits        10449     9938     -511     
+ Misses       2082     2020      -62     

Flag	Coverage Δ
unittests	?
unittests-Instrumentation-Experimental	25.10% <11.42%> (?)
unittests-Instrumentation-Stable	25.10% <11.42%> (?)
unittests-Solution-Experimental	83.05% <100.00%> (?)
unittests-Solution-Stable	83.08% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/OpenTelemetry.Api/Baggage.cs	100.00% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs	89.72% <100.00%> (+0.14%)	⬆️

... and 31 files with indirect coverage changes

[ngruson]

@vishweshbankwar : Something like this?
The unit test covers the scenario where creating the new activity is skipped.
The existing unit test SuccessfulTemplateControllerCallUsesParentContext handles the scenario where the new activity is being created.

[vishweshbankwar]

This should be NET6_0_OR_GREATER? IHttpActivityFeature is available in net6.0.

[ngruson]

I had to add the Microsoft.Extensions.Features package to the test app to be able to build with net6.0.
See the project file.
Should this be made conditional in the project file?
I didn't succeed right off the bat.

[vishweshbankwar]

Try this

context.Features.Get<IHttpActivityFeature>()?.Activity;

[cijothomas]

Please changelog entry before merge.

[github-actions]

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

[ngruson]

Who needs to review this next? The PR was marked stale.

[cijothomas]

Who needs to review this next? The PR was marked stale.

Apologies. Vishwesh is travelling and will be back in Jan only. One of the other approvers will re-review this. Thanks for waiting!

[alanwest]

@ngruson When you have a chance, please add a changelog entry #5136 (comment) and I'll get this PR merged.