-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[logs] Fix pooling issues when wrapping batch export processor #5255
Merged
CodeBlanch
merged 11 commits into
open-telemetry:main
from
CodeBlanch:logs-shared-pool-improvements
Jan 30, 2024
Merged
[logs] Fix pooling issues when wrapping batch export processor #5255
CodeBlanch
merged 11 commits into
open-telemetry:main
from
CodeBlanch:logs-shared-pool-improvements
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… another processor.
CodeBlanch
added
pkg:OpenTelemetry
Issues related to OpenTelemetry NuGet package
logs
Logging signal related
labels
Jan 24, 2024
1 task
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5255 +/- ##
==========================================
- Coverage 83.38% 83.06% -0.33%
==========================================
Files 297 272 -25
Lines 12531 11985 -546
==========================================
- Hits 10449 9955 -494
+ Misses 2082 2030 -52
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rajkumar-rangaraj
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kielek
approved these changes
Jan 26, 2024
vishweshbankwar
approved these changes
Jan 29, 2024
cijothomas
approved these changes
Jan 29, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5250
Changes
BatchLogRecordExportProcessor
andBatch<T>
to only returnLogRecord
s to the shared pool if they were rented from it.Details
If the SDK detects a batch processor it switches to a shared pool of LogRecords. This works fine for all of the OOB stuff and registration extensions. However if you wrap the
BatchLogRecordExportProcessor
inside some other processor (see #5250) it won't be detected and the SDK will choose theThreadStatic
pool.What this PR does is make
BatchLogRecordExportProcessor
andBatch<T>
aware that it might be used with non-pooled records.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes