-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk-metrics] Support setting exemplar filter from spec envvar key #5412
[sdk-metrics] Support setting exemplar filter from spec envvar key #5412
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5412 +/- ##
==========================================
+ Coverage 83.38% 84.71% +1.33%
==========================================
Files 297 281 -16
Lines 12531 12097 -434
==========================================
- Hits 10449 10248 -201
+ Misses 2082 1849 -233
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a nit about changelog being more self-contained, but that is not a 🚫
Changes
OTEL_METRICS_EXEMPLAR_FILTER
.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes