Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Support setting exemplar filter from spec envvar key #5412

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Mar 5, 2024

Changes

  • Adds support for configuring exemplar filter via OTEL_METRICS_EXEMPLAR_FILTER.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package metrics Metrics signal related labels Mar 5, 2024
@CodeBlanch CodeBlanch requested a review from a team March 5, 2024 18:58
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (6250307) to head (ec4849e).
Report is 112 commits behind head on main.

❗ Current head ec4849e differs from pull request most recent head aa7d236. Consider uploading reports for the commit aa7d236 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5412      +/-   ##
==========================================
+ Coverage   83.38%   84.71%   +1.33%     
==========================================
  Files         297      281      -16     
  Lines       12531    12097     -434     
==========================================
- Hits        10449    10248     -201     
+ Misses       2082     1849     -233     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 84.70% <100.00%> (?)
unittests-Solution-Stable 84.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/MeterProviderSdk.cs 95.08% <100.00%> (+7.24%) ⬆️
src/OpenTelemetry/Metrics/MetricReaderExt.cs 91.42% <100.00%> (+1.42%) ⬆️

... and 55 files with indirect coverage changes

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a nit about changelog being more self-contained, but that is not a 🚫

@CodeBlanch CodeBlanch merged commit 123c0b4 into open-telemetry:main Mar 5, 2024
37 checks passed
@CodeBlanch CodeBlanch deleted the sdk-metrics-exemplarfilter-envvar branch March 5, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants