Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Remove AppContext verification when using grpc + insecure endpoints #5486

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Mar 28, 2024

Fixes N/A
Design discussion issue N/A

Changes

Drop all references to System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport. It was needed for .NET Core 3.x only. Now, only .NET6+ is supported so the code can be removed.

For sure 2 first commits can be merged. I have some doubts about 7379247. Formally, there is no support to .NET Core 3.x in this repository but exporter package is targeted to netstandard2.0 and netstndard2.1. Both can be technically referenced by .NET Core 3.x. Not supported per discsion in this PR.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes N/A
  • [ ] Changes in public API reviewed (if applicable) N/A

…rt in examples

library targets .NET8. The switch is not needed
…er.Http2UnencryptedSupport

The lowest supported version is .NET6. Switch is not needed
….Http.SocketsHttpHandler.Http2UnencryptedSupport

.NET Core 3.x is no longer supported
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (6250307) to head (c607314).
Report is 153 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5486      +/-   ##
==========================================
+ Coverage   83.38%   85.53%   +2.14%     
==========================================
  Files         297      289       -8     
  Lines       12531    12593      +62     
==========================================
+ Hits        10449    10771     +322     
+ Misses       2082     1822     -260     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.51% <ø> (?)
unittests-Solution-Stable 85.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mentation/ExportClient/BaseOtlpGrpcExportClient.cs 78.94% <ø> (-5.27%) ⬇️

... and 62 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review March 28, 2024 12:05
@Kielek Kielek requested a review from a team March 28, 2024 12:05
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @Kielek Could you please update the PR description with the link https://learn.microsoft.com/en-us/aspnet/core/grpc/troubleshoot?view=aspnetcore-8.0#call-insecure-grpc-services-with-net-core-client

Regarding the question on using netstandard2.0 with netcoreapp3.1, we do not support this scenario. #3767

@Kielek
Copy link
Contributor Author

Kielek commented Mar 28, 2024

LGTM - @Kielek Could you please update the PR description with the link https://learn.microsoft.com/en-us/aspnet/core/grpc/troubleshoot?view=aspnetcore-8.0#call-insecure-grpc-services-with-net-core-client

Done.

Regarding the question on using netstandard2.0 with netcoreapp3.1, we do not support this scenario. #3767

Great! All commits can be merged.

@CodeBlanch CodeBlanch added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Mar 28, 2024
@CodeBlanch CodeBlanch changed the title Drop references to System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport [otlp] Remove AppContext verification when using grpc + insecure endpoints Mar 28, 2024
Kielek and others added 2 commits March 29, 2024 06:45
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
@CodeBlanch CodeBlanch merged commit 2e30089 into open-telemetry:main Mar 29, 2024
33 checks passed
@Kielek Kielek deleted the drop-Http2UnencryptedSupport branch March 29, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants