-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk-metrics] Support .NET 9 Synchronous Gauge #5867
[sdk-metrics] Support .NET 9 Synchronous Gauge #5867
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5867 +/- ##
==========================================
+ Coverage 83.38% 86.28% +2.89%
==========================================
Files 297 257 -40
Lines 12531 11214 -1317
==========================================
- Hits 10449 9676 -773
+ Misses 2082 1538 -544
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would you also update the docs? For example
| [Gauge](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#gauge) (experimental) | N/A | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Do you know if it should trigger any changes on instrumentation (packages) side?
Contrib repository/natively instrumented packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good.
Requesting changes to ensure the test covers a corner case with Gauge and Temporality, see https://github.com/open-telemetry/opentelemetry-dotnet/pull/5867/files#r1778773598
Not yet, need to investigate it. |
Fixes #4805
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Updated the
Metric
class to add support for synchronous gauge.Follow up: Update document - #5868
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes