[otlp] Remove the direct dependency on Microsoft.Extensions.Configuration.Binder #5951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder from Otlp project.
github-actions
bot
added
infra
Kielek
approved these changes
Nov 4, 2024
reyang
reviewed
Nov 4, 2024
| @@ -7,6 +7,9 @@ Notes](../../RELEASENOTES.md). | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Removed the direct dependency on `Microsoft.Extensions.Configuration.Binder`. | |||
There was a problem hiding this comment.
Define needed 😄 Agree it is kind of silly to mention. Checked with @alanwest he was good with it NOT being mentioned so I removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5951 +/- ##
==========================================
+ Coverage 83.38% 86.38% +3.00%
==========================================
Files 297 262 -35
Lines 12531 11804 -727
==========================================
- Hits 10449 10197 -252
+ Misses 2082 1607 -475
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Microsoft.Extensions.Configuration.Binderfrom the OtlpExporter project.Details
The SDK depends on
Microsoft.Extensions.Logging.Configurationwhich brings inMicrosoft.Extensions.Configuration.Binder. The1.9.0version of SDK brought in8.0.0versions of those packages. It seems OtlpExporter needed 8.0.1 to make AoT work correctly. Now that SDK is bringing in9.0.0versions of packages this redirect is no longer required.Merge requirement checklist