Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Clean up class structure in metrics tests #5960

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

CodeBlanch
Copy link
Member

Follow-up to #5956

Changes

  • A bunch of class structure was introduced to be able to test everything with and without delta metricpoint reclaim being enabled. Now that it is always enabled, this structure isn't required.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated

@CodeBlanch CodeBlanch requested a review from a team as a code owner November 8, 2024 21:27
@github-actions github-actions bot added pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (6250307) to head (3096d21).
Report is 381 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5960      +/-   ##
==========================================
+ Coverage   83.38%   86.70%   +3.32%     
==========================================
  Files         297      263      -34     
  Lines       12531    11931     -600     
==========================================
- Hits        10449    10345     -104     
+ Misses       2082     1586     -496     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.50% <ø> (?)
unittests-Project-Stable 86.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 242 files with indirect coverage changes

@xiang17
Copy link
Contributor

xiang17 commented Nov 8, 2024

The MetricPointReclaimTestsBase and MetricOverflowAttributeTestsBase classes are also the same pattern but missing in this PR.

@CodeBlanch
Copy link
Member Author

The MetricPointReclaimTestsBase and MetricOverflowAttributeTestsBase classes are also the same pattern but missing in this PR.

@xiang17 Updated!

@CodeBlanch CodeBlanch merged commit 2aae6e1 into open-telemetry:main Nov 9, 2024
33 checks passed
@CodeBlanch CodeBlanch deleted the metrics-test-cleanup branch November 9, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants