Upgrade gopsutil package used in instrumentation/host #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantorrie
requested review from
Aneurysm9,
dashpole,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1330 +/- ##
=====================================
Coverage 68.2% 68.2%
=====================================
Files 119 119
Lines 5200 5200
=====================================
Hits 3550 3550
Misses 1511 1511
Partials 139 139
|
jmacd
approved these changes
Oct 5, 2021
|
Note I'd like to see #1144 merge first, conflicts either way. |
|
I've incorporated this into #1144 as I also had these test errors. |
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Move global code to toplevel package * Move version function to toplevel package * Update changelog Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gopsutil-v2.x was failing during tests on my Mac. Took the opportunity to upgrade it to the next major version
gopsutil-v3.xwhich no longer fails.Also updated this particular instrumentation to use the new API from
go.opentelemetry.io/otel/metric-v0.24.0