Fix bug where an empty exemplar was added to counters #5395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5395 +/- ##
=====================================
Coverage 62.1% 62.1%
=====================================
Files 186 186
Lines 11527 11537 +10
=====================================
+ Hits 7166 7176 +10
Misses 4149 4149
Partials 212 212
|
MrAlias
reviewed
Apr 15, 2024
MrAlias
approved these changes
Apr 15, 2024
dmathieu
approved these changes
Apr 16, 2024
pellared
approved these changes
Apr 16, 2024
scorpionknifes
pushed a commit
to scorpionknifes/opentelemetry-go-contrib
that referenced
this pull request
Apr 24, 2024
scorpionknifes
pushed a commit
to scorpionknifes/opentelemetry-go-contrib
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5383
I also found out that the +Inf bucket is only sometimes added to the proto format: https://github.com/prometheus/client_golang/blob/d038ab96c0c7b9cd217a39072febd610bcdf1fd8/prometheus/metric.go#L189
That meant we were dropping the highest histogram bucket if users were not using exemplars.
@gouthamve