Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP migration, Env Var name #5997

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

MadVikingGod
Copy link
Contributor

@MadVikingGod MadVikingGod commented Aug 8, 2024

This change renames the environment variable used for compatibility mode to OTEL_SEMCONV_STABILITY_OPT_IN as per the recommendation in the spec.

Follow up from this comment.

@MadVikingGod MadVikingGod requested a review from dmathieu as a code owner August 8, 2024 18:23
@MadVikingGod MadVikingGod requested a review from a team August 8, 2024 18:23
@MrAlias
Copy link
Contributor

MrAlias commented Aug 8, 2024

cc @VinozzZ

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.5%. Comparing base (bb9ac54) to head (07ad52a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5997   +/-   ##
=====================================
  Coverage   65.5%   65.5%           
=====================================
  Files        203     203           
  Lines      12918   12918           
=====================================
  Hits        8466    8466           
  Misses      4198    4198           
  Partials     254     254           
Files Coverage Δ
...entation/net/http/otelhttp/internal/semconv/env.go 88.6% <100.0%> (ø)

@dashpole dashpole closed this Aug 15, 2024
@dashpole dashpole reopened this Aug 15, 2024
@dashpole dashpole added this to the v1.29.0 milestone Aug 15, 2024
@dashpole dashpole merged commit a32ef13 into open-telemetry:main Aug 16, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants