Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify the instrumentation package within the scope #444

Closed
MrAlias opened this issue Nov 1, 2023 · 2 comments · Fixed by #507
Closed

Identify the instrumentation package within the scope #444

MrAlias opened this issue Nov 1, 2023 · 2 comments · Fixed by #507
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Nov 1, 2023

Currently, the scope for instrumentation (the Tracer name used) is set loosely around the target package of the instrumentation:

These do not adequately identify the instrumentation library being used to produce the telemetry.

Proposal

  1. Update the instrumentation names to have a prefix of go.opentelemetry.io/auto/.
  2. Unify any client/server distinction (this distinction is made via the span kind)

For example:

  • "go.opentelemetry.io/auto/database/sql"
  • "go.opentelemetry.io/auto/github.com/gin-gonic/gin"
  • "go.opentelemetry.io/auto/google.golang.org/grpc"
  • "go.opentelemetry.io/auto/net/http"
@MrAlias
Copy link
Contributor Author

MrAlias commented Nov 1, 2023

2. Unify any client/server distinction (this distinction is made via the span kind)

This cannot be done without modifying the Manager logic. It assumes a unique identifier from each probe and uses the LibraryName to do this.

@MrAlias
Copy link
Contributor Author

MrAlias commented Nov 1, 2023

  1. Unify any client/server distinction (this distinction is made via the span kind)

This cannot be done without modifying the Manager logic. It assumes a unique identifier from each probe and uses the LibraryName to do this.

The manifest being proposed in #419 can solve this issue. It can contain a unique identifying name the manager can use as well as the scope name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant