We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, the scope for instrumentation (the Tracer name used) is set loosely around the target package of the instrumentation:
Tracer
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/database/sql/probe.go
Line 45 in f29abc7
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/github.com/gin-gonic/gin/probe.go
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/google.golang.org/grpc/probe.go
Line 69 in f29abc7
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/google.golang.org/grpc/server/probe.go
Line 68 in f29abc7
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/net/http/server/probe.go
Line 43 in f29abc7
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/net/http/client/probe.go
Line 66 in f29abc7
These do not adequately identify the instrumentation library being used to produce the telemetry.
go.opentelemetry.io/auto/
For example:
"go.opentelemetry.io/auto/database/sql"
"go.opentelemetry.io/auto/github.com/gin-gonic/gin"
"go.opentelemetry.io/auto/google.golang.org/grpc"
"go.opentelemetry.io/auto/net/http"
The text was updated successfully, but these errors were encountered:
2. Unify any client/server distinction (this distinction is made via the span kind)
This cannot be done without modifying the Manager logic. It assumes a unique identifier from each probe and uses the LibraryName to do this.
Manager
LibraryName
Sorry, something went wrong.
Unify any client/server distinction (this distinction is made via the span kind) This cannot be done without modifying the Manager logic. It assumes a unique identifier from each probe and uses the LibraryName to do this.
Unify any client/server distinction (this distinction is made via the span kind)
The manifest being proposed in #419 can solve this issue. It can contain a unique identifying name the manager can use as well as the scope name.
Successfully merging a pull request may close this issue.
Currently, the scope for instrumentation (the
Tracer
name used) is set loosely around the target package of the instrumentation:opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/database/sql/probe.go
Line 45 in f29abc7
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/github.com/gin-gonic/gin/probe.go
Line 45 in f29abc7
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/google.golang.org/grpc/probe.go
Line 69 in f29abc7
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/google.golang.org/grpc/server/probe.go
Line 68 in f29abc7
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/net/http/server/probe.go
Line 43 in f29abc7
opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/net/http/client/probe.go
Line 66 in f29abc7
These do not adequately identify the instrumentation library being used to produce the telemetry.
Proposal
go.opentelemetry.io/auto/
.For example:
"go.opentelemetry.io/auto/database/sql"
"go.opentelemetry.io/auto/github.com/gin-gonic/gin"
"go.opentelemetry.io/auto/google.golang.org/grpc"
"go.opentelemetry.io/auto/net/http"
The text was updated successfully, but these errors were encountered: