Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OTel recommended naming for instrumentation scope #507

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Use OTel recommended naming for instrumentation scope #507

merged 7 commits into from
Nov 16, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 15, 2023 •
edited
Loading

Resolve #444

  • Identify the instrumentation package in the instrumentation scope by using the instrumented package with a prefix of go.opentelemetry.io/auto as the scope name.
  • Unify client/server telemetry under the same scope.

@MrAlias MrAlias changed the title Identify the instrumented pkg within the scope Identify the instrumented package within the scope name Nov 15, 2023
@MrAlias MrAlias changed the title Identify the instrumented package within the scope name Use OTel recommended naming for instrumentation scope Nov 15, 2023
@MrAlias MrAlias marked this pull request as ready for review November 16, 2023 00:41
@MrAlias MrAlias requested a review from a team November 16, 2023 00:41
@MrAlias MrAlias merged commit 73bb7a9 into open-telemetry:main Nov 16, 2023
13 of 14 checks passed
@MrAlias MrAlias deleted the inst-name branch November 16, 2023 15:39
@MrAlias MrAlias added this to the v0.9.0-alpha milestone Dec 12, 2023
@MrAlias MrAlias mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeNFed edeNFed edeNFed approved these changes

@pellared pellared pellared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0-alpha
Development

Successfully merging this pull request may close these issues.

Identify the instrumentation package within the scope
3 participants
@MrAlias @pellared @edeNFed