Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offset generation cache #762

Closed
MrAlias opened this issue Apr 9, 2024 · 2 comments · Fixed by #781
Closed

Fix offset generation cache #762

MrAlias opened this issue Apr 9, 2024 · 2 comments · Fixed by #781
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 9, 2024

I noticed that if I rebuild the offsetgen tool, delete the entries from the json file, and run it for the first time it gets it right, and the second time it puts all these wrong values, so I'm guessing there is some bug in the cache mechanism there.

Originally posted by @RonFed in #740 (comment)

@RonFed RonFed linked a pull request Apr 19, 2024 that will close this issue
@damemi
Copy link
Contributor

damemi commented Apr 22, 2024

+1 I'm also seeing weird behavior with the cache when trying to add fields in #790. Just running make docker-offsets caused the existing versions to get wiped and replaced with repeated {} entries. Deleting .tools/ and internal/pkg/inject/offset_results.json then re-running the tool seems to work

@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 22, 2024

@damemi can you check if #781 resolves your issue?

@MrAlias MrAlias added this to the v0.12.0-alpha milestone May 14, 2024
@MrAlias MrAlias modified the milestones: v0.12.0-alpha, v0.13.0-alpha Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants