Fix offsetgen #781
Merged
Fix offsetgen #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entry. Fix fallback to single offset only when version is unknown
…re using the intended version
This was
linked to
issues
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the regression described in Fix the correctness of offsets #509
Also, this should fix Support template paths as part of span names for go versions >= 1.22 #740 (comment)
go get <mod>@versioncommand toBuilderfor cases where we look for offsets that are not part of go std lib. This makes sure we are using the correct version. This fixes the problem of un-expected versions the tool found offsets for.