-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Add grpc instrumentation e2e test #106
Conversation
…-go-instrumentation into mike/grpc-test
I've tested the app runs and calls the grpc server. Do we know for sure grpc instrumentation is working? |
No, we don't 😄 Check out #78 . That was the main drive behind wanting a test on this sooner than later. Did you create the |
Looks like the sample job is timing out in the CI failure: https://github.com/open-telemetry/opentelemetry-go-instrumentation/actions/runs/4811053910/jobs/8564536923?pr=106#step:15:5 Checking out your branch and running
|
…trumentation into mike/grpc-test # Conflicts: # .github/workflows/kind.yml # Makefile
Also blocked by: |
…trumentation into mike/grpc-test
…trumentation into mike/grpc-test
Going to wait for #150 as it resolves part of the issue I was working through. The content of the traces json still has some fixes that we'll need to resolve. |
can successfully run `make fixture-grpc` some of the probe redaction can likely be removed once open-telemetry#150 is merged into this branch
@MikeGoldsmith it looks like #150 has merged. Are you still planning to work on this? |
Superseded by #453 |
Add e2e test for grpc instrumentation.