Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithPID InstrumentationOption #355

Merged
merged 15 commits into from
Oct 9, 2023
Merged

Add WithPID InstrumentationOption #355

merged 15 commits into from
Oct 9, 2023

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Sep 29, 2023 •
edited
Loading

Currently, there are 3 ways to specify the instrumented target. Ordered by precadence from high to low:

  1. WithPid: specifying the pid has the highest precedence and saves looking for the pid (DiscoverProcessID will return immediately in that case)
  2. OTEL_GO_AUTO_TARGET_EXE env var
  3. WithTarget specifying the executable

@RonFed RonFed requested a review from a team September 29, 2023 16:27
@RonFed RonFed mentioned this pull request Sep 29, 2023
Closed
edeNFed
edeNFed approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@edeNFed edeNFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edeNFed edeNFed merged commit d2dedd1 into open-telemetry:main Oct 9, 2023
12 checks passed
@RonFed RonFed mentioned this pull request Oct 11, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeNFed edeNFed edeNFed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RonFed @edeNFed