Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract go version and compiler from instrumneted process #811

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Apr 30, 2024

The process.runtime.version and process.runtime.name resource attributes should be extracted from the instrumented process and not from the agent one.
The rest of the resource attributes such as OS and ARCH are common to the agent and the app.

@RonFed RonFed requested a review from a team April 30, 2024 12:46
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

CHANGELOG.md Outdated Show resolved Hide resolved
RonFed and others added 2 commits April 30, 2024 23:06
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias MrAlias merged commit e5e2c08 into open-telemetry:main Apr 30, 2024
17 checks passed
@MrAlias MrAlias added this to the v0.12.0-alpha milestone May 14, 2024
@MrAlias MrAlias modified the milestones: v0.12.0-alpha, v0.13.0-alpha Jun 4, 2024
@MrAlias MrAlias mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants