Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit go.mod for e2e test apps #820

Merged
merged 12 commits into from
May 7, 2024
Merged

Conversation

damemi
Copy link
Contributor

@damemi damemi commented May 6, 2024

Similar to #650 for the public samples, this commits the go.mod/go.sum files for each e2e sample app.

I hit an issue with this in this test failure where our gRPC e2e was failing with:

 > [4/4] RUN go mod init go.opentelemetry.io/auto/internal/test/e2e/grpc && go mod tidy && go build -o main:
0.702 go: found google.golang.org/grpc/examples/helloworld/helloworld in google.golang.org/grpc/examples v0.0.0-20240506165903-befc29de931d
0.704 go: downloading google.golang.org/protobuf v1.33.0
0.708 go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237
0.733 go: downloading google.golang.org/genproto v0.0.0-20240227224415-6ceb2ff114de
0.946 go: downloading github.com/google/go-cmp v0.6.0
0.982 go: downloading golang.org/x/net v0.23.0
1.256 go: downloading golang.org/x/sys v0.18.0
1.505 go: downloading golang.org/x/text v0.14.0
14.86 # google.golang.org/grpc/examples/helloworld/helloworld
Error: 14.86 /go/pkg/mod/google.golang.org/grpc/examples@v0.0.0-20240506165903-befc29de931d/helloworld/helloworld/helloworld_grpc.pb.go:33:16: undefined: grpc.SupportPackageIsVersion9

Digging into it, this was because the google.golang.org/grpc/examples dependency for our e2e was updated 3 days ago. But, because we don't pin a specific version of this package (and they don't actually publish tagged versions of the examples/helloworld package), our e2es will just pull from latest. This causes a conflict trying to depend on unreleased code.

This PR commits all of the go.mod files for our e2es and removes that step from their dockerfiles. We should be doing this anyway for consistency in our tests, rather than running a fresh go mod init within the test.

@damemi
Copy link
Contributor Author

damemi commented May 6, 2024

Including offset update from #821 to pass CI

@MrAlias
Copy link
Contributor

MrAlias commented May 6, 2024

Looks like the 1.22 toolchain is not available for the 1.21 integration test.

@MrAlias
Copy link
Contributor

MrAlias commented May 6, 2024

Looks like the 1.22 toolchain is not available for the 1.21 integration test.

Do we need 1.21 tests? Can we just say development is done on latest?

internal/test/e2e/grpc/main Outdated Show resolved Hide resolved
@damemi damemi force-pushed the update-grpc branch 2 times, most recently from f0677e1 to 21ac0c3 Compare May 7, 2024 14:08
@damemi
Copy link
Contributor Author

damemi commented May 7, 2024

Looks like the 1.22 toolchain is not available for the 1.21 integration test.

Do we need 1.21 tests? Can we just say development is done on latest?

I just updated it to work, had to set go 1.22.0 in the go.mod

@MrAlias MrAlias merged commit 6f4487d into open-telemetry:main May 7, 2024
17 checks passed
@MrAlias MrAlias added this to the v0.12.0-alpha milestone May 14, 2024
@MrAlias MrAlias modified the milestones: v0.12.0-alpha, v0.13.0-alpha Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants