-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit go.mod
for e2e test apps
#820
Conversation
Including offset update from #821 to pass CI |
Looks like the 1.22 toolchain is not available for the 1.21 integration test. |
Do we need 1.21 tests? Can we just say development is done on latest? |
f0677e1
to
21ac0c3
Compare
I just updated it to work, had to set |
Similar to #650 for the public samples, this commits the
go.mod
/go.sum
files for each e2e sample app.I hit an issue with this in this test failure where our gRPC e2e was failing with:
Digging into it, this was because the
google.golang.org/grpc/examples
dependency for our e2e was updated 3 days ago. But, because we don't pin a specific version of this package (and they don't actually publish tagged versions of theexamples/helloworld
package), our e2es will just pull from latest. This causes a conflict trying to depend on unreleased code.This PR commits all of the
go.mod
files for our e2es and removes that step from their dockerfiles. We should be doing this anyway for consistency in our tests, rather than running a freshgo mod init
within the test.