Skip to content

Commit

Permalink
Refactor SDK span creation and implementation (#2213)
Browse files Browse the repository at this point in the history
* Refactor startSpanInternal into a tracer method

The span creation and configuration process is split across the tracer
Start method and the startSpanInternal function, each living in
different files. This adds confusion when developing. It requires the
developer to remember certain parts of the configuration happen in one
place or the other.

This unifies the creation and configuration of a new span. It makes this
unification by creating a newSpan method on the tracer. This method will
do all the configuration needed for a new span other than setting the
execution task tracker. This remains a part of the Start method to
preserve any existing timing and tracing the already exists.

* Add a non-recording span to the SDK

* Assign returned context from runtime trace task

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
  • Loading branch information
MrAlias and Aneurysm9 authored Sep 2, 2021
1 parent db317fc commit c7ae470
Show file tree
Hide file tree
Showing 3 changed files with 218 additions and 174 deletions.
Loading

0 comments on commit c7ae470

Please sign in to comment.