You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this also ties in to the concept of a "propagation span" that only has a span context and is non-recording. I think with the IsRemote predicate on span contexts we're now closer to being able to simply stick a span into a context with only a remote span context and let the SDK figure out what to do with it when starting a new span.
I think this also ties in to the concept of a "propagation span" that only has a span context and is non-recording. I think with the IsRemote predicate on span contexts we're now closer to being able to simply stick a span into a context with only a remote span context and let the SDK figure out what to do with it when starting a new span.
Agreed! That is a change I am working on submitting here (which will resolve "Reconsider the context keys"). It requires this to merge first, but I think we can achieve this now.
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this issue
Mar 29, 2021
Remove HasRemoteParent fields from SamplingParameters. The
HasRemoteParent field is a duplicate of the Remote field of the parent
span context contained in the ParentContext.
Change the `ParentContext` field from storing a `SpanContext` to a
`context.Context` that holds the parent span. This is to conform with
the OpenTelemetry specification and resolveopen-telemetry#1727.
* Update SamplingParameters
Remove HasRemoteParent fields from SamplingParameters. The
HasRemoteParent field is a duplicate of the Remote field of the parent
span context contained in the ParentContext.
Change the `ParentContext` field from storing a `SpanContext` to a
`context.Context` that holds the parent span. This is to conform with
the OpenTelemetry specification and resolve#1727.
* Update PR number
Currently we use the following sampling decision parameteres:
opentelemetry-go/sdk/trace/sampling.go
Lines 31 to 40 in 90bd4ab
The specification requires:
This likely needs to be addressed more holistically here first.
The text was updated successfully, but these errors were encountered: