Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on intitialization of Simple SpanProcessor #1875

Closed
Aneurysm9 opened this issue May 3, 2021 · 5 comments · Fixed by #3854
Closed

Warn on intitialization of Simple SpanProcessor #1875

Aneurysm9 opened this issue May 3, 2021 · 5 comments · Fixed by #3854
Labels
area:trace Part of OpenTelemetry tracing enhancement New feature or request help wanted Extra attention is needed pkg:SDK Related to an SDK package
Milestone

Comments

@Aneurysm9
Copy link
Member

Problem Statement

The simpleSpanProcessor is not intended for use outside of development and debugging. However, many early examples and demos included its use and users report with some regularity performance issues caused by its use.

Proposed Solution

We should emit a warning when NewSimpleSpanProcessor() is invoked.

Alternatives

Documentation and examples have already been updated to use a batch span processor.

@Aneurysm9 Aneurysm9 added enhancement New feature or request good first issue Good for newcomers pkg:SDK Related to an SDK package area:trace Part of OpenTelemetry tracing labels May 3, 2021
@MrAlias
Copy link
Contributor

MrAlias commented May 3, 2021

We should likely standardize on a logging solution before this so we do not end up with disparate solutions here: #1068

@Aneurysm9 Aneurysm9 removed the good first issue Good for newcomers label May 3, 2021
@MrAlias MrAlias added the help wanted Extra attention is needed label Oct 12, 2022
@dubonzi
Copy link
Contributor

dubonzi commented Mar 7, 2023

Hi, I'd like to work on this.

Looking at the global logger implementation, there isn't a Warn function, would Info be sufficient in this case?

@pellared
Copy link
Member

pellared commented Mar 9, 2023

@dubonzi I think the API can be extended to have a Warn function

@dubonzi
Copy link
Contributor

dubonzi commented Mar 9, 2023

@pellared Would that have to be on it's own issue?

@pellared
Copy link
Member

pellared commented Mar 9, 2023

It can be part of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing enhancement New feature or request help wanted Extra attention is needed pkg:SDK Related to an SDK package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants