Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on intitialization of Simple SpanProcessor #3854

Merged
merged 6 commits into from
Mar 24, 2023

Conversation

dubonzi
Copy link
Contributor

@dubonzi dubonzi commented Mar 10, 2023

Ended up not creating a Warn function as mentioned in the issue since Info is already being used for warning messages in other places.

Resolves #1875

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a changelog entry.

sdk/trace/simple_span_processor.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #3854 (1503ce5) into main (de497de) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3854     +/-   ##
=======================================
- Coverage   81.8%   81.7%   -0.1%     
=======================================
  Files        170     170             
  Lines      12909   12911      +2     
=======================================
- Hits       10561   10559      -2     
- Misses      2129    2133      +4     
  Partials     219     219             
Impacted Files Coverage Δ
sdk/trace/simple_span_processor.go 75.4% <100.0%> (+0.8%) ⬆️

... and 2 files with indirect coverage changes

CHANGELOG.md Outdated Show resolved Hide resolved
@dubonzi dubonzi requested a review from dmathieu March 10, 2023 12:06
@pellared
Copy link
Member

pellared commented Mar 13, 2023

Ended up not creating a Warn function as mentioned in the issue since Info is already being used for warning messages in other places.

I will create an issue for it.

EDIT: #3866

@dubonzi
Copy link
Contributor Author

dubonzi commented Mar 24, 2023

I just rebased and switched to using the new Warn function added in #3900.

@dubonzi dubonzi requested a review from pellared March 24, 2023 01:25
@MrAlias MrAlias merged commit b73a33c into open-telemetry:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on intitialization of Simple SpanProcessor
5 participants