-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn on intitialization of Simple SpanProcessor #3854
Warn on intitialization of Simple SpanProcessor #3854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a changelog entry.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3854 +/- ##
=======================================
- Coverage 81.8% 81.7% -0.1%
=======================================
Files 170 170
Lines 12909 12911 +2
=======================================
- Hits 10561 10559 -2
- Misses 2129 2133 +4
Partials 219 219
|
I will create an issue for it. EDIT: #3866 |
7323743
to
6ae1616
Compare
I just rebased and switched to using the new |
Ended up not creating a
Warn
function as mentioned in the issue sinceInfo
is already being used for warning messages in other places.Resolves #1875