Update the metric `Export` interface to accept a `*ResourceMetrics` instead of `ResourceMetrics` #3852

MrAlias · 2023-03-09T17:05:48Z

Line 52 in e463505

Export(context.Context, metricdata.ResourceMetrics) error

Given Go is a pass-by-value language, passing the already allocated pointer would reduce the call-stack size.

Originally posted by @MrAlias in #3760 (comment)

MrAlias mentioned this issue Mar 9, 2023

Reuse memory in metric pipelines #3760

Merged

MrAlias added help wanted Extra attention is needed good first issue Good for newcomers pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Mar 9, 2023

unicod3 mentioned this issue Mar 9, 2023

Update the metric Export interface to accept a *ResourceMetrics instead of ResourceMetrics #3853

Merged

MrAlias closed this as completed in #3853 Mar 16, 2023

MrAlias added this to the Metric SDK v0.38.0 milestone Mar 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the metric `Export` interface to accept a `*ResourceMetrics` instead of `ResourceMetrics` #3852

Update the metric `Export` interface to accept a `*ResourceMetrics` instead of `ResourceMetrics` #3852

MrAlias commented Mar 9, 2023 •

edited

Loading

Update the metric Export interface to accept a *ResourceMetrics instead of ResourceMetrics #3852

Update the metric Export interface to accept a *ResourceMetrics instead of ResourceMetrics #3852

Comments

MrAlias commented Mar 9, 2023 • edited Loading

Update the metric `Export` interface to accept a `*ResourceMetrics` instead of `ResourceMetrics` #3852

Update the metric `Export` interface to accept a `*ResourceMetrics` instead of `ResourceMetrics` #3852

MrAlias commented Mar 9, 2023 •

edited

Loading