-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse memory in metric pipelines #3760
Merged
MrAlias
merged 11 commits into
open-telemetry:main
from
MadVikingGod:mvg/update_producer
Mar 9, 2023
Merged
Reuse memory in metric pipelines #3760
MrAlias
merged 11 commits into
open-telemetry:main
from
MadVikingGod:mvg/update_producer
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
February 21, 2023 19:53
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3760 +/- ##
=======================================
- Coverage 81.6% 81.6% -0.1%
=======================================
Files 168 169 +1
Lines 12477 12489 +12
=======================================
+ Hits 10193 10201 +8
- Misses 2069 2073 +4
Partials 215 215
|
dashpole
approved these changes
Feb 21, 2023
MrAlias
added
pkg:SDK
Related to an SDK package
area:metrics
Part of OpenTelemetry Metrics
labels
Feb 23, 2023
MrAlias
reviewed
Feb 23, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
reviewed
Feb 27, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Petrie
reviewed
Mar 3, 2023
MrAlias
changed the title
Reuse memory in in pipelines.
Reuse memory in metric pipelines
Mar 3, 2023
MrAlias
reviewed
Mar 3, 2023
MrAlias
reviewed
Mar 3, 2023
Co-authored-by: Peter Liu <lpfvip2008@gmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:metrics
Part of OpenTelemetry Metrics
pkg:SDK
Related to an SDK package
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change starts the process of reusing memory from slices.
This does reduce the number of allocations in the histogram benchmark to 4x the number of collects