Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to configure the exporter buffer of the BatchProcessor #5238

Closed
MrAlias opened this issue Apr 19, 2024 · 0 comments · Fixed by #5877
Closed

Add an option to configure the exporter buffer of the BatchProcessor #5238

MrAlias opened this issue Apr 19, 2024 · 0 comments · Fixed by #5877
Labels
area:logs Part of OpenTelemetry logs enhancement New feature or request pkg:SDK Related to an SDK package
Milestone
v1.31.0

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 19, 2024 •
edited
Loading

Currently the buffer size is 1:

opentelemetry-go/sdk/log/batch.go

Lines 117 to 118 in 1ea4ee2

// TODO: explore making the size of this configurable.
exporter: newBufferExporter(exporter, 1),

Users may find it useful to be able to configure this value. A BatchOption could be added to achieve this.

leave a 👍 if you would find this useful
@MrAlias MrAlias mentioned this issue Apr 19, 2024
Closed
8 tasks
@MrAlias MrAlias changed the title Add option for users to configure the exporter buffer Add an option to configure the exporter buffer of the BatchProcessor Apr 19, 2024
@MrAlias MrAlias added enhancement New feature or request pkg:SDK Related to an SDK package area:logs Part of OpenTelemetry logs labels Apr 19, 2024
@MrAlias MrAlias moved this to Blocked in Go: Logs (Post-GA) Apr 19, 2024
@MrAlias MrAlias moved this from Blocked to Backlog in Go: Logs (Post-GA) Apr 19, 2024
@amanakin amanakin mentioned this issue May 16, 2024
Closed
@Frapschen Frapschen mentioned this issue Oct 8, 2024
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Go: Logs (Post-GA) Oct 10, 2024
@XSAM XSAM modified the milestones: untracked, v1.31.0 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:logs Part of OpenTelemetry logs enhancement New feature or request pkg:SDK Related to an SDK package
Projects
Go: Logs (Post-GA)
Status: Done
Milestone
v1.31.0
Development

Successfully merging a pull request may close this issue.

Add an option to configure the exporter buffer of the BatchProcessor Frapschen/opentelemetry-go
2 participants
@MrAlias @XSAM