Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log/sdk: Implement BatchingProcessor #5063

Closed
8 tasks done
pellared opened this issue Mar 13, 2024 · 1 comment
Closed
8 tasks done

log/sdk: Implement BatchingProcessor #5063

pellared opened this issue Mar 13, 2024 · 1 comment
Assignees
@MrAlias
Labels
area:logs Part of OpenTelemetry logs pkg:SDK Related to an SDK package
Milestone
untracked

Comments

@pellared
Copy link
Member

pellared commented Mar 13, 2024 •
edited by MrAlias
Loading

@pellared pellared converted this from a draft issue Mar 13, 2024
@pellared pellared added pkg:SDK Related to an SDK package area:logs Part of OpenTelemetry logs labels Mar 13, 2024
@pellared pellared moved this from Backlog to Todo in Go: Logs (GA) Mar 13, 2024
@MrAlias MrAlias self-assigned this Mar 19, 2024
@MrAlias MrAlias moved this from Todo to In Progress in Go: Logs (GA) Mar 19, 2024
This was referenced Mar 19, 2024
Merged
Merged
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this issue Mar 25, 2024
@MrAlias
Add export sync
02089f3 
The batching log processor will generate records from 4 different
locations (polling, OnEmit, ForceFlush, Shutdown). In order to ensure an
Exporter is called serially, as is required by the interface, this
function will be used in the processor to centralize the interaction
with its Exporter.

Part of open-telemetry#5063.

See open-telemetry#5093 for the implementation use.
This was referenced Mar 25, 2024
Merged
Closed
@pellared pellared mentioned this issue Mar 26, 2024
Closed
MrAlias added a commit that referenced this issue Mar 27, 2024
@MrAlias @XSAM
Add export sync (#5105)
321219b 
* Add export sync

The batching log processor will generate records from 4 different
locations (polling, OnEmit, ForceFlush, Shutdown). In order to ensure an
Exporter is called serially, as is required by the interface, this
function will be used in the processor to centralize the interaction
with its Exporter.

Part of #5063.

See #5093 for the implementation use.

* Concurrent safe testExporter

---------

Co-authored-by: Sam Xie <sam@samxie.me>
This was referenced Mar 29, 2024
Merged
Merged
Merged
Merged
@MrAlias MrAlias mentioned this issue Apr 19, 2024
Merged
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this issue Apr 19, 2024
@MrAlias
Default implementation for empty BatchProcessor
6fa33f5 
Ensure an empty BatchProcessor does not panic when any method is called.

Initialize the empty BatchProcessor to use the default/envar setup if
not created with NewBatchProcessor.

Part of open-telemetry#5063
@MrAlias MrAlias mentioned this issue Apr 19, 2024
Merged
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this issue Apr 19, 2024
@MrAlias
Default implementation for empty BatchProcessor
bc49ecb 
Ensure an empty BatchProcessor does not panic when any method is called.
Default an empty BatchProcessor as being shut down.

Part of open-telemetry#5063
@MrAlias
Copy link
Contributor

MrAlias commented Apr 24, 2024

Quick look at pooling export payloads didn't show large improvements in performance. Going to remove from this issue as a task. We can address later if more time is found to dedicate into the investigation.

@MrAlias MrAlias closed this as completed Apr 24, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Logs (GA) Apr 24, 2024
@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:logs Part of OpenTelemetry logs pkg:SDK Related to an SDK package
Projects
Go: Logs (GA)
Status: Done
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

sdk/log: Implement BatchingProcessor pellared/opentelemetry-go
3 participants
@pellared @MrAlias @XSAM