Implement retry policy for the OTLP/gRPC exporter #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paivagustavo
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1832 +/- ##
=====================================
Coverage 78.6% 78.7%
=====================================
Files 137 137
Lines 7305 7373 +68
=====================================
+ Hits 5749 5808 +59
- Misses 1313 1321 +8
- Partials 243 244 +1
|
paivagustavo
added
pkg:exporter:otlp
Aneurysm9
approved these changes
Apr 21, 2021
MrAlias
reviewed
Apr 22, 2021
pellared
reviewed
Apr 26, 2021
pellared
reviewed
Apr 26, 2021
pellared
reviewed
Apr 27, 2021
pellared
reviewed
Apr 27, 2021
pellared
reviewed
Apr 27, 2021
pellared
reviewed
Apr 27, 2021
pellared
approved these changes
Apr 27, 2021
MrAlias
approved these changes
Apr 27, 2021
MadVikingGod
approved these changes
Apr 28, 2021
Aneurysm9
approved these changes
Apr 29, 2021
tigrannajaryan
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Apr 29, 2021
## Changes The transient errors table in the `protocol/exporter.md` specify `Permission Denied` and `Unauthenticated` errors as retryable, but they're defined as _permanent_ error in the [otep-35](https://github.com/open-telemetry/oteps/blob/main/text/0035-opentelemetry-protocol.md#export-response) and in the `protocol/otlp.md` file. ### Related issues This was found while implementing [retries in the go sdk](open-telemetry/opentelemetry-go#1832 (comment)).
Merged
1 task
tigrannajaryan
pushed a commit
to tigrannajaryan/opentelemetry-proto
that referenced
this pull request
Apr 20, 2023
## Changes The transient errors table in the `protocol/exporter.md` specify `Permission Denied` and `Unauthenticated` errors as retryable, but they're defined as _permanent_ error in the [otep-35](https://github.com/open-telemetry/oteps/blob/main/text/0035-opentelemetry-protocol.md#export-response) and in the `protocol/otlp.md` file. ### Related issues This was found while implementing [retries in the go sdk](open-telemetry/opentelemetry-go#1832 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1632