-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft to change oteltest to use the sdk #2075
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This PR is to prove how easily an oteltest package can be implemented on top of the SDK, and avoid 1000+ duplicate code lines. |
@@ -6,6 +6,7 @@ require ( | |||
github.com/google/go-cmp v0.5.6 | |||
github.com/stretchr/testify v1.7.0 | |||
go.opentelemetry.io/otel/oteltest v1.0.0-RC1 | |||
go.opentelemetry.io/otel/sdk v1.0.0-RC1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the API module and MUST NOT
depend on any SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API module probably MUST NOT depend on the oteltest :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aneurysm9 if you resolve #2077 then this will go away :D
Fixes #2072
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com