Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metric instrument names in InstrumentKind #2089

Closed
wants to merge 2 commits into from

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jul 15, 2021

For the InstrumentKind enum in the metric package, this modernizes the instrument names.

Counter -> SyncCounter
UpDownCounter -> SyncUpDownCounter
SumObserver -> AsyncCounter
UpDownSumObserver -> AsyncUpDownCounter
ValueRecorder -> SyncHistogram
ValueObserver -> AsyncGauge

These names have been finalized in the Metrics SIG. This does not change the API in any other way, just updates these constant names.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #2089 (c8e61ad) into main (12f737c) will decrease coverage by 0.0%.
The diff coverage is 62.5%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2089     +/-   ##
=======================================
- Coverage   72.8%   72.8%   -0.1%     
=======================================
  Files        166     166             
  Lines       8168    8168             
=======================================
- Hits        5953    5949      -4     
- Misses      1987    1989      +2     
- Partials     228     230      +2     
Impacted Files Coverage Δ
...rs/otlp/otlpmetric/internal/otlpmetrictest/data.go 0.0% <0.0%> (ø)
...tlp/otlpmetric/internal/otlpmetrictest/otlptest.go 0.0% <0.0%> (ø)
metric/instrumentkind_string.go 33.3% <ø> (ø)
metric/metric.go 51.9% <77.7%> (ø)
bridge/opencensus/exporter.go 100.0% <100.0%> (ø)
metric/metric_instrument.go 87.4% <100.0%> (ø)
sdk/export/metric/metric.go 36.8% <100.0%> (ø)
sdk/metric/aggregator/aggregator.go 100.0% <100.0%> (ø)
sdk/metric/selector/simple/simple.go 100.0% <100.0%> (ø)
sdk/metric/refcount_mapped.go 77.7% <0.0%> (-22.3%) ⬇️
... and 1 more

@jmacd
Copy link
Contributor Author

jmacd commented Jul 19, 2021

I will re-open this following #2091.

@jmacd jmacd closed this Jul 19, 2021
@jmacd jmacd deleted the jmacd/newnames branch October 1, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant