-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the otlp trace exporter limit of SpanEvents when exporting #2616
Merged
MrAlias
merged 13 commits into
open-telemetry:main
from
hanyuancheung:bugfix-remove-export-maxEventsPerSpan
Feb 17, 2022
Merged
Remove the otlp trace exporter limit of SpanEvents when exporting #2616
MrAlias
merged 13 commits into
open-telemetry:main
from
hanyuancheung:bugfix-remove-export-maxEventsPerSpan
Feb 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanyuancheung
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod and
pellared
as code owners
February 16, 2022 08:49
Codecov Report
@@ Coverage Diff @@
## main #2616 +/- ##
=======================================
- Coverage 76.2% 76.1% -0.1%
=======================================
Files 173 173
Lines 12234 12234
=======================================
- Hits 9324 9320 -4
- Misses 2667 2671 +4
Partials 243 243
|
XSAM
reviewed
Feb 16, 2022
Co-authored-by: Sam Xie <xsambundy@gmail.com>
Co-authored-by: Sam Xie <xsambundy@gmail.com>
Co-authored-by: Sam Xie <xsambundy@gmail.com>
Co-authored-by: Sam Xie <xsambundy@gmail.com>
XSAM
approved these changes
Feb 16, 2022
pellared
approved these changes
Feb 16, 2022
pellared
reviewed
Feb 16, 2022
MadVikingGod
approved these changes
Feb 16, 2022
MrAlias
approved these changes
Feb 16, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hanyuancheung
changed the title
Remove the limit of SpanEvents when exporting
Remove the otlp trace exporter limit of SpanEvents when exporting
Feb 17, 2022
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2607
Remove the limit of SpanEvents when exporting.