Adds metrics Global #2660
Merged
Adds metrics Global #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
pellared and
hanyuancheung
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2660 +/- ##
=======================================
+ Coverage 75.9% 76.5% +0.5%
=======================================
Files 174 178 +4
Lines 11748 12072 +324
=======================================
+ Hits 8926 9244 +318
+ Misses 2612 2603 -9
- Partials 210 225 +15
|
Aneurysm9
reviewed
Mar 7, 2022
jmacd
approved these changes
Mar 8, 2022
dashpole
approved these changes
Mar 8, 2022
Changed name of global API. Added stop to all race tests go routine. Added race tests for other instruments.
MrAlias
reviewed
Mar 10, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
reviewed
Mar 11, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
reviewed
Mar 12, 2022
XSAM
reviewed
Mar 17, 2022
XSAM
reviewed
Mar 22, 2022
XSAM
approved these changes
Mar 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2650
This creates a global package that can eventually be moved to
internal/globalwhen the metrics API is stable. Users should use themetric/globalAPI to set and Obtain the global MeterProvider, which will remain and be deprecated after the API is stable.