Support general attribute limits for spans #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When model specific limits are not set fallback to the general ones defined by environment variables before defaults for attribute length and count limits. This is in compliance with the specification.
Test all environment variable helper functions.
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2677 +/- ##
=====================================
Coverage 75.8% 75.8%
=====================================
Files 173 173
Lines 11672 11684 +12
=====================================
+ Hits 8854 8866 +12
Misses 2608 2608
Partials 210 210
|
Aneurysm9
approved these changes
Mar 15, 2022
hanyuancheung
approved these changes
Mar 16, 2022
plantfansam
approved these changes
Mar 16, 2022
…it-and-otel_attribute_count_limit
MrAlias
deleted the
2675-support-otel_attribute_value_length_limit-and-otel_attribute_count_limit
branch
This was referenced Mar 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2675
When model specific limits are not set fallback to the general ones defined by environment variables before defaults for attribute length and count limits. This is in compliance with the specification.
Testing
Refactor
envpackage tests to cover all environment variable helper functions, including the ones added in this PR.