Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go 1.18 to our supported versions. #2679

Merged
merged 7 commits into from
Mar 18, 2022
Merged

Add Go 1.18 to our supported versions. #2679

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f278af
Adds go1.18 to tests, moves default version to 1.17
MadVikingGod Mar 16, 2022
7c8a5be
Added note to readme.
MadVikingGod Mar 16, 2022
e80e69a
Update CHANGELOG.md
hanyuancheung Mar 17, 2022
67cc5a7
Update README.md
MadVikingGod Mar 18, 2022
a12ad0f
Move default go version back to 1.16
MadVikingGod Mar 18, 2022
a882d0a
Merge branch 'main' into mvg/go1.18
MrAlias Mar 18, 2022
9594255
Move changelog entry to unreleased section
MrAlias Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches:
- main
env:
DEFAULT_GO_VERSION: 1.16
DEFAULT_GO_VERSION: 1.17
MrAlias marked this conversation as resolved.
Show resolved Hide resolved
jobs:
benchmark:
name: Benchmarks
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ env:
# Path to where test results will be saved.
TEST_RESULTS: /tmp/test-results
# Default minimum version of Go to support.
DEFAULT_GO_VERSION: 1.16
DEFAULT_GO_VERSION: 1.17
jobs:
lint:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
compatibility-test:
strategy:
matrix:
go-version: [1.17, 1.16]
go-version: [1.18, 1.17, 1.16]
os: [ubuntu-latest, macos-latest, windows-latest]
# GitHub Actions does not support arm* architectures on default
# runners. It is possible to acomplish this with a self-hosted runner
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ This update is a breaking change of the unstable Metrics API. Code instrumented
Zero or negative values will not be changed to the default value like `WithSpanLimits` does.
Setting a limit to zero will effectively disable the related resource it limits and setting to a negative value will mean that resource is unlimited.
Consequentially, limits should be constructed using `NewSpanLimits` and updated accordingly. (#2637)
- Add go 1.18 to our compatibility tests. (#2679)
MrAlias marked this conversation as resolved.
Show resolved Hide resolved

### Changed

Expand Down
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,27 @@ This project is tested on the following systems.

| OS | Go Version | Architecture |
| ------- | ---------- | ------------ |
| Ubuntu | 1.18 | amd64 |
| Ubuntu | 1.17 | amd64 |
| Ubuntu | 1.16 | amd64 |
| Ubuntu | 1.18 | 386 |
| Ubuntu | 1.17 | 386 |
| Ubuntu | 1.16 | 386 |
| MacOS | 1.18 | amd64 |
| MacOS | 1.17 | amd64 |
| MacOS | 1.16 | amd64 |
| Windows | 1.18 | amd64 |
| Windows | 1.17 | amd64 |
| Windows | 1.16 | amd64 |
| Windows | 1.18 | 386 |
| Windows | 1.17 | 386 |
| Windows | 1.16 | 386 |

While this project should work for other systems, no compatibility guarantees
are made for those systems currently.

Go 1.18 was added in March of 2022. Go 1.16 will be removed around June 2022
MadVikingGod marked this conversation as resolved.
Show resolved Hide resolved

## Getting Started

You can find a getting started guide on [opentelemetry.io](https://opentelemetry.io/docs/go/getting-started/).
Expand Down