Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle partial success response from OTLP server in otlpmetric exporters #3440

Merged
merged 7 commits into from
Nov 9, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 3, 2022

Fix #3162

@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package labels Nov 3, 2022
@MrAlias MrAlias added this to the Metric v0.34.0 milestone Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #3440 (04833b2) into main (2694dbf) will increase coverage by 0.0%.
The diff coverage is 61.2%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3440   +/-   ##
=====================================
  Coverage   77.6%   77.6%           
=====================================
  Files        164     164           
  Lines      11572   11651   +79     
=====================================
+ Hits        8988    9052   +64     
- Misses      2377    2390   +13     
- Partials     207     209    +2     
Impacted Files Coverage Δ
...orters/otlp/otlpmetric/internal/otest/collector.go 6.8% <0.0%> (-0.4%) ⬇️
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 76.6% <68.4%> (-0.9%) ⬇️
exporters/otlp/otlpmetric/internal/otest/client.go 97.1% <100.0%> (+1.9%) ⬆️
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 85.7% <100.0%> (+0.8%) ⬆️
sdk/trace/batch_span_processor.go 81.1% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias merged commit 484c8bd into open-telemetry:main Nov 9, 2022
@MrAlias MrAlias deleted the otlpmetric-part-success branch November 9, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Partial-success responses for OTLP metrics
3 participants