Accept scope attributes during Meter creation #3738
Merged
+68
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:API
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3738 +/- ##
======================================
Coverage ? 81.6%
======================================
Files ? 166
Lines ? 12432
Branches ? 0
======================================
Hits ? 10154
Misses ? 2063
Partials ? 215
|
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
approved these changes
Feb 16, 2023
Likely these attributes will be stored as a Set in the SDK. Don't cause two conversions because we return a slice here.
dmathieu
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3368
The OTel specification requires the instrumentation attributes are accepted by the API for the
Meter. This adds aMeterOptionto satisfy that requirement.