Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do no silently drop unknown schema data #3743

Merged
merged 6 commits into from
Feb 21, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 17, 2023

Resolve #3742

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #3743 (6249622) into main (f78f72d) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3743   +/-   ##
=====================================
  Coverage   81.6%   81.6%           
=====================================
  Files        166     166           
  Lines      12431   12432    +1     
=====================================
+ Hits       10144   10154   +10     
+ Misses      2071    2063    -8     
+ Partials     216     215    -1     
Impacted Files Coverage Δ
schema/v1.1/parser.go 73.9% <100.0%> (+14.8%) ⬆️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+1.7%) ⬆️

@MrAlias MrAlias merged commit de94faf into open-telemetry:main Feb 21, 2023
@MrAlias MrAlias deleted the schema-err-unknown branch February 21, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not silently drop invalid schema fields
5 participants