Move metric No-Op to metric/noop
#3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" (open-telemetry#3921)" This reverts commit 795ad97.
MrAlias
added
pkg:API
pellared
approved these changes
Mar 27, 2023
pellared
reviewed
Mar 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3941 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 170 170
Lines 12943 12949 +6
=====================================
+ Hits 10583 10588 +5
- Misses 2137 2138 +1
Partials 223 223
|
Co-authored-by: Robert Pająk <pellared@hotmail.com>
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
Aneurysm9
approved these changes
Mar 27, 2023
pellared
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of this proposal expected to be rejected, this adds back the
nooppackage. It reverts the revert commit 795ad97, adding #3893 back.